Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appveyor #173

Merged
merged 3 commits into from
Aug 2, 2018
Merged

Appveyor #173

merged 3 commits into from
Aug 2, 2018

Conversation

eatkins
Copy link
Contributor

@eatkins eatkins commented Aug 2, 2018

No description provided.

@eatkins eatkins mentioned this pull request Aug 2, 2018
@eatkins
Copy link
Contributor Author

eatkins commented Aug 2, 2018

Here is an example of a passing appveyor build:
https://ci.appveyor.com/project/eatkins/io/build/1.0.18

This will enable us to run tests in a windows environment during CI. I
am only running io/test since the formatting and binary compatibility
tests are handled by travis and appveyor do not provide as many build
agents as travis.
After adding the .appveyor.yml, I found that my builds would typically
fail and usually one of the polling watch service threads died with an
IOException with message "CreateFile() failed with error 5." I tracked
this down to ERROR_ACCESS_DENIED, which seemed weird since any of the
files that were being polled were generated by the test. It turns out
that windows will return ERROR_ACCESS_DENIED when the file was in a
pending delete state.
https://stackoverflow.com/questions/6680491/why-does-windows-return-error-access-denied-when-i-try-to-open-a-delete-pended-f
While this feels slightly wrong, it doesn't seem completely unreasonable
to consider ERROR_ACCESS_DENIED to be like a FileNotFoundException. In
either the deleted or privileged file cases, the file is effectively not
findable.

An alternative would be to throw a different exception and catch that in
getModifiedTimeOrZero.

Bonus: remove unused import
I was seeing transient failures of this test on windows, which has
significantly slower file access apis than linux and osx.
@eatkins eatkins requested a review from cunei August 2, 2018 01:24
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n eed3si9n merged commit 265cba2 into sbt:1.2.x Aug 2, 2018
@eatkins eatkins deleted the appveyor branch October 9, 2018 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants